Revert "[ADT] Deprecate the redirection from SmallSet to SmallPtrSet (Take 2) (#155078) #155622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-adt Author: Mehdi Amini (joker-eph) ChangesThis reverts commit 9b493dc. There are hundreds of warnings when building LLVM/Clang because of this right now. See the original PR for the detailed issues. Also revert the follow-up fix "[ADT] Fix redirection of SmallSet to SmallPtrSet (#155117)" This reverts commit 3ca1ca4. Full diff: https://github.com/llvm/llvm-project/pull/155622.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/SmallSet.h b/llvm/include/llvm/ADT/SmallSet.h
index 4c60b15224a45..eb434bcb71717 100644
--- a/llvm/include/llvm/ADT/SmallSet.h
+++ b/llvm/include/llvm/ADT/SmallSet.h
@@ -268,17 +268,8 @@ class SmallSet {
/// If this set is of pointer values, transparently switch over to using
/// SmallPtrSet for performance.
-///
-/// We use this middleman class DeprecatedSmallSet so that the deprecation
-/// warning works. Placing LLVM_DEPRECATED just before SmallSet below won't
-/// work.
-template <typename PointerType, unsigned N>
-class LLVM_DEPRECATED("Use SmallPtrSet instead", "SmallPtrSet")
- DeprecatedSmallSet : public SmallPtrSet<PointerType, N> {};
-
template <typename PointeeType, unsigned N>
-class SmallSet<PointeeType *, N> : public DeprecatedSmallSet<PointeeType *, N> {
-};
+class SmallSet<PointeeType*, N> : public SmallPtrSet<PointeeType*, N> {};
/// Equality comparison for SmallSet.
///
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
kazutakahirata
approved these changes
Aug 27, 2025
…(Take 2) (llvm#155078)" This reverts commit 9b493dc. There are hundreds of warnings when building LLVM/Clang because of this right now. See the original PR for the detailed issues. Also revert the follow-up fix "[ADT] Fix redirection of SmallSet to SmallPtrSet (llvm#155117)" This reverts commit 3ca1ca4.
cf4c6f7 to
19fbe39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9b493dc.
There are hundreds of warnings when building LLVM/Clang because of this right now. See the original PR for the detailed issues.
Also revert the follow-up fix "[ADT] Fix redirection of SmallSet to SmallPtrSet (#155117)" This reverts commit 3ca1ca4.