Skip to content

[llvm-exegesis] Follow up of 810ac29cfe81cbd8f2e97d06f0acd540f841c754 #155624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

[llvm-exegesis] Follow up of 810ac29cfe81cbd8f2e97d06f0acd540f841c754 #155624

merged 1 commit into from
Aug 27, 2025

Conversation

sjoerdmeijer
Copy link
Collaborator

Disable the test case for now as it still shows slightly different codegen in a stage2 build, which is not wrong, but needs to investigated why it is happening.

@sjoerdmeijer
[llvm-exegesis] Follow up of 810ac29
bcce0c4 
Disable the test case for now as it still shows slightly different
codegen in a stage2 build, which is not wrong, but needs to investigated
why it is happening.
@llvmbot
Copy link
Member

llvmbot commented Aug 27, 2025

@llvm/pr-subscribers-tools-llvm-exegesis

Author: Sjoerd Meijer (sjoerdmeijer)

Changes

Disable the test case for now as it still shows slightly different codegen in a stage2 build, which is not wrong, but needs to investigated why it is happening.

Full diff: https://github.com/llvm/llvm-project/pull/155624.diff

1 Files Affected:

  • (modified) llvm/test/tools/llvm-exegesis/AArch64/loop-register.s (+6)
diff --git a/llvm/test/tools/llvm-exegesis/AArch64/loop-register.s b/llvm/test/tools/llvm-exegesis/AArch64/loop-register.s
index 62040b26c8faf..632088455e75a 100644
--- a/llvm/test/tools/llvm-exegesis/AArch64/loop-register.s
+++ b/llvm/test/tools/llvm-exegesis/AArch64/loop-register.s
@@ -1,3 +1,9 @@
+; FIXME: this test fails with a stage2 build, in which case it seems to
+; generate extra function prologue instructions that interfere with matching
+; the STR of X19. Disable this for now.
+;
+; UNSUPPORTED: *
+
 REQUIRES: aarch64-registered-target, asserts
 
 RUN: llvm-exegesis -mcpu=neoverse-v2 --use-dummy-perf-counters --mode=latency --debug-only=print-gen-assembly --opcode-name=ADDVv4i16v -repetition-mode=loop 2>&1 | FileCheck %s

@sjoerdmeijer sjoerdmeijer merged commit f3a5c16 into llvm:main Aug 27, 2025
9 of 11 checks passed
@zeroomega
Copy link
Contributor

We are seeing test failures on linux-arm64 after this patch got landed. Error message:

Exception during script execution:
Traceback (most recent call last):
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/BooleanExpression.py", line 32, in evaluate
    return parser.parseAll()
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/BooleanExpression.py", line 151, in parseAll
    self.token = next(self.tokens)
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/BooleanExpression.py", line 62, in tokenize
    raise ValueError("couldn't parse text: %r" % string)
ValueError: couldn't parse text: '*'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/Test.py", line 420, in getUnsupportedFeatures
    return [
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/Test.py", line 423, in <listcomp>
    if BooleanExpression.evaluate(item, features)
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/BooleanExpression.py", line 34, in evaluate
    raise ValueError(str(e) + ("\nin expression: %r" % string))
ValueError: couldn't parse text: '*'
in expression: '*'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/worker.py", line 77, in _execute_test_handle_errors
    result = test.config.test_format.execute(test, lit_config)
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/formats/shtest.py", line 29, in execute
    return lit.TestRunner.executeShTest(
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/TestRunner.py", line 2344, in executeShTest
    parsed = parseIntegratedTestScript(test, require_script=not script)
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/TestRunner.py", line 2228, in parseIntegratedTestScript
    unsupported_features = test.getUnsupportedFeatures()
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/Test.py", line 426, in getUnsupportedFeatures
    raise ValueError("Error in UNSUPPORTED list:\n%s" % str(e))
ValueError: Error in UNSUPPORTED list:
couldn't parse text: '*'
in expression: '*'

Looks like the wildcard "*" doesn't work and lit has issue to parse it.

@zeroomega
Copy link
Contributor

From the official guide: https://llvm.org/docs/TestingGuide.html#constraining-test-execution
It has to be UNSUPPORTED: target={{.*}}

@zeroomega zeroomega mentioned this pull request Aug 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tools:llvm-exegesis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjoerdmeijer @llvmbot @zeroomega