Skip to content

[MLIR][Python][NFC] move Py* types #155719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[MLIR][Python][NFC] move Py* types #155719

wants to merge 3 commits into from
+2,574 −2,344

Conversation

makslevental
Copy link
Contributor

WIP

@makslevental makslevental changed the title [MLIR][Python] make Py* types public API [MLIR][Python][NFC] move Py* types Aug 27, 2025
@makslevental makslevental force-pushed the users/makslevental/deprecate-mlir_subclass branch 8 times, most recently from 7eb55a3 to 06eb0f6 Compare August 28, 2025 01:04
@makslevental
Copy link
Contributor Author

Turns out Interop.h is order-sensitive: https://github.com/llvm/llvm-project/actions/runs/17282729060/job/49054132346?pr=155719#step:4:6491

@makslevental makslevental force-pushed the users/makslevental/deprecate-mlir_subclass branch from 06eb0f6 to 7df100f Compare August 28, 2025 01:30
@makslevental makslevental force-pushed the users/makslevental/deprecate-mlir_subclass branch from 7df100f to cbcfaee Compare August 28, 2025 01:31
rolfmorel
rolfmorel reviewed Aug 28, 2025
View reviewed changes
mlir/lib/Bindings/Python/IRAttributes.cpp
mlirAttributes.reserve(nb::len(attributes));
for (auto attribute : attributes) {
mlirAttributes.push_back(pyTryCast<PyAttribute>(attribute));
[](const nb::sequence &py_values, DefaultingPyMlirContext ctx) {
Copy link
Contributor

@rolfmorel rolfmorel Aug 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random spot check: nb::list to nb::sequence - nice!

rolfmorel
rolfmorel reviewed Aug 28, 2025
View reviewed changes
mlir/lib/Bindings/Python/IRAttributes.cpp
if (is_true < 0) {
throw nb::python_error();
}
values.push_back(is_true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random spot check: you're pushing is_true here, which I believe is a Boolean value and not the attribute element itself. I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfmorel rolfmorel rolfmorel left review comments

@ftynse ftynse Awaiting requested review from ftynse ftynse will be requested when the pull request is marked ready for review ftynse is a code owner

@stellaraccident stellaraccident Awaiting requested review from stellaraccident stellaraccident will be requested when the pull request is marked ready for review stellaraccident is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makslevental @rolfmorel