Skip to content

Conversation

ashgti
Copy link
Contributor

@ashgti ashgti commented Aug 27, 2025

Fixes lldb-mcp, aa71d95 was merged after 71a065e.

@ashgti ashgti marked this pull request as ready for review August 27, 2025 23:31
@ashgti ashgti requested a review from JDevlieghere as a code owner August 27, 2025 23:31
@llvmbot llvmbot added the lldb label Aug 27, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 27, 2025

@llvm/pr-subscribers-lldb

Author: John Harrison (ashgti)

Changes

Fixes lldb-mcp, aa71d95 was merged after 71a065e.


Full diff: https://github.com/llvm/llvm-project/pull/155720.diff

1 Files Affected:

  • (modified) lldb/tools/lldb-mcp/lldb-mcp.cpp (+1-1)
diff --git a/lldb/tools/lldb-mcp/lldb-mcp.cpp b/lldb/tools/lldb-mcp/lldb-mcp.cpp
index 42daabbe4da2f..a1a835aaa0a58 100644
--- a/lldb/tools/lldb-mcp/lldb-mcp.cpp
+++ b/lldb/tools/lldb-mcp/lldb-mcp.cpp
@@ -63,7 +63,7 @@ int main(int argc, char *argv[]) {
         [](MainLoopBase &loop) { loop.RequestTermination(); });
   });
 
-  auto transport_up = std::make_unique<lldb_protocol::mcp::MCPTransport>(
+  auto transport_up = std::make_unique<lldb_protocol::mcp::Transport>(
       input, output, std::string(client_name),
       [&](llvm::StringRef message) { llvm::errs() << message << '\n'; });
 

@ashgti
Copy link
Contributor Author

ashgti commented Aug 27, 2025

Submitting to unblock CI.

@ashgti ashgti merged commit de1baa5 into llvm:main Aug 27, 2025
13 checks passed
@JDevlieghere
Copy link
Member

Thanks!

mstorsjo added a commit that referenced this pull request Aug 28, 2025
This reverts commit de1baa5.

This is needed as the other renaming commit was reverted in
1bb8db5.
t-a-james pushed a commit to t-a-james/llvm-project that referenced this pull request Aug 28, 2025
…oject into bugprone-method-hiding

* 'bugprone-method-hiding' of github.com:t-a-james/llvm-project: (230 commits)
  [SimplifyCFG] Move token type check into canReplaceOperandWithVariable()
  [ADT] Fix signed integer overflow (llvm#155826)
  [Offload] Update LIBOMPTARGET_INFO text for `attach` map-type. (llvm#155509)
  [CMake][AIX] Enable CMP0182: Create shared library archives by default (llvm#155686)
  AMDGPU: Add tests for atomics with AGPR operands (llvm#155820)
  [AArch64] Split zero cycle zeoring per register class (llvm#154561)
  [gn build] Port fa883e1
  [mlir][tosa] Allow shift operand of tosa::MulOp as non-constant (llvm#155197)
  [AArch64][NFC] Add MCInstrAnalysis unittests (llvm#155609)
  [Offload][OpenMP] Tests require libc on GPU for printf (llvm#155785)
  AMDGPU: Add missing verifier tests for load/store AGPR case (llvm#155815)
  [lldb-mcp] Fix building for Windows
  Revert "[lldb] Correct a usage after a rename was merged. (llvm#155720)"
  Revert "[lldb] NFC Moving mcp::Transport into its own file. (llvm#155711)"
  [lldb][test] Run ranges::ref_vew test only for libc++ (llvm#155813)
  [SCCP][FuncSpec] Poison unreachable constant global variable user (llvm#155753)
  [LoongArch] Lowering v32i8 vector mask generation to `VMSKLTZ` (llvm#149953)
  [flang][docs][NFC] Remove stray backtick (llvm#154974)
  [MLIR] Apply clang-tidy fixes for misc-use-internal-linkage in LinalgOps.cpp (NFC)
  [MLIR] Apply clang-tidy fixes for performance-move-const-arg in VariantValue.cpp (NFC)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants