[CI] Handle Runtime Build Failures Correctly in generate_test_report #155730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nested ninja invocations currently confuse the script. Update the script to handle this correctly and a test to ensure we do not regress this behavior in the future.
DavidSpickett
approved these changes
Aug 28, 2025
| # ninja invocations. The sub-ninja will print that a subcommand failed, | ||
| # and then the outer ninja will list the command that failed. We should | ||
| # ignore the outer failure. | ||
| if ninja_log[index - 1].startswith("ninja: build stopped:"): |
There was a problem hiding this comment.
Was going to say why not check that the two commands are the same for a bit more certainty that you're in this specific situation, but they won't be, right?
The outer ninja's command will be something like "move to runtimes directory and invoke ninja" and the inner one is "build this runtime source file".
There was a problem hiding this comment.
Yeah, exactly. The inner ninja will fail on whatever actually failed and the outer ninja will fail on the invoking the inner ninja.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nested ninja invocations currently confuse the script. Update the script to handle this correctly and a test to ensure we do not regress this behavior in the future.