Skip to content

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Aug 28, 2025

No description provided.

@arsenm arsenm marked this pull request as ready for review August 28, 2025 06:50
Copy link
Contributor Author

arsenm commented Aug 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@llvmbot
Copy link
Member

llvmbot commented Aug 28, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Matt Arsenault (arsenm)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/155767.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp (+3)
diff --git a/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp b/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
index 6f2ea8ad1ff01..263f7127fbf10 100644
--- a/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
+++ b/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
@@ -2466,6 +2466,9 @@ SILoadStoreOptimizer::collectMergeableInsts(
       continue;
 
     if (CI.InstClass == DS_WRITE && CI.IsAGPR) {
+      LLVM_DEBUG(
+          dbgs() << "cannot merge ds writes with mixed AGPR and VGPR data\n");
+
       // FIXME: nothing is illegal in a ds_write2 opcode with two AGPR data
       //        operands. However we are reporting that ds_write2 shall have
       //        only VGPR data so that machine copy propagation does not

@arsenm arsenm merged commit 88d0751 into main Aug 29, 2025
13 checks passed
@arsenm arsenm deleted the users/arsenm/amdgpu/add-debug-print-load-store-opt-ds-write2-agpr branch August 29, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants