[ADT] Teach SmallSetVector to inherit constructors (NFC) #155788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch teaches SmallSetVector to inherit constructors from the base class with "using". This way, we can remove all of the manually defined constructors in SmallSetVector.
|
@llvm/pr-subscribers-llvm-adt Author: Kazu Hirata (kazutakahirata) ChangesThis patch teaches SmallSetVector to inherit constructors from the Full diff: https://github.com/llvm/llvm-project/pull/155788.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/SetVector.h b/llvm/include/llvm/ADT/SetVector.h
index 85d4f2d5ee28a..deed62187ee12 100644
--- a/llvm/include/llvm/ADT/SetVector.h
+++ b/llvm/include/llvm/ADT/SetVector.h
@@ -377,17 +377,7 @@ class SetVector {
template <typename T, unsigned N>
class SmallSetVector : public SetVector<T, SmallVector<T, N>, DenseSet<T>, N> {
public:
- SmallSetVector() = default;
-
- /// Initialize a SmallSetVector with a range of elements
- template<typename It>
- SmallSetVector(It Start, It End) {
- this->insert(Start, End);
- }
-
- template <typename Range>
- SmallSetVector(llvm::from_range_t, Range &&R)
- : SmallSetVector(adl_begin(R), adl_end(R)) {}
+ using SetVector<T, SmallVector<T, N>, DenseSet<T>, N>::SetVector;
};
} // end namespace llvm
|
arsenm
approved these changes
Aug 28, 2025
kuhar
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch teaches SmallSetVector to inherit constructors from the
base class with "using". This way, we can remove all of the manually
defined constructors in SmallSetVector.