[ADT] Define SetVector::count in terms of SetVector::contains (NFC) #155789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can avoid repeating the same code in count by delegating to contains. While I am at it, this patch adds [[nodiscard] to contains and count.
|
@llvm/pr-subscribers-llvm-adt Author: Kazu Hirata (kazutakahirata) ChangesWe can avoid repeating the same code in count by delegating to While I am at it, this patch adds [[nodiscard] to contains and count. Full diff: https://github.com/llvm/llvm-project/pull/155789.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/SetVector.h b/llvm/include/llvm/ADT/SetVector.h
index 85d4f2d5ee28a..ecd39f2809fb8 100644
--- a/llvm/include/llvm/ADT/SetVector.h
+++ b/llvm/include/llvm/ADT/SetVector.h
@@ -261,7 +261,7 @@ class SetVector {
}
/// Check if the SetVector contains the given key.
- bool contains(const key_type &key) const {
+ [[nodiscard]] bool contains(const key_type &key) const {
if constexpr (canBeSmall())
if (isSmall())
return is_contained(vector_, key);
@@ -271,12 +271,8 @@ class SetVector {
/// Count the number of elements of a given key in the SetVector.
/// \returns 0 if the element is not in the SetVector, 1 if it is.
- size_type count(const key_type &key) const {
- if constexpr (canBeSmall())
- if (isSmall())
- return is_contained(vector_, key);
-
- return set_.count(key);
+ [[nodiscard]] size_type count(const key_type &key) const {
+ return contains(key) ? 1 : 0;
}
/// Completely clear the SetVector
|
arsenm
approved these changes
Aug 28, 2025
kuhar
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can avoid repeating the same code in count by delegating to
contains.
While I am at it, this patch adds [[nodiscard] to contains and count.