[mlir][nvgpu] Delete nvgpu dialect unused variable kMaxTMALastdimByte (NFC) #155825
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-nvgpu @llvm/pr-subscribers-mlir-gpu Author: lonely eagle (linuxlonelyeagle) ChangesSince the size of the last dimension of TMA is no longer fixed at 128 bytes, remove the kMaxTMALastdimByte. Full diff: https://github.com/llvm/llvm-project/pull/155825.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/NVGPU/IR/NVGPUDialect.h b/mlir/include/mlir/Dialect/NVGPU/IR/NVGPUDialect.h
index 61a57fb60bda4..b07e1a5beb866 100644
--- a/mlir/include/mlir/Dialect/NVGPU/IR/NVGPUDialect.h
+++ b/mlir/include/mlir/Dialect/NVGPU/IR/NVGPUDialect.h
@@ -46,8 +46,6 @@ constexpr unsigned kMaxTMATensorDimension = 5;
/// to be traversed along each of the kMaxTMATensorDimension (tensorRank)
/// dimensions, must be non-zero and less than or equal to 256.
constexpr unsigned kMaxTMADimension = 256;
-/// Last dimension of 2D+ TMA must be 128 bytes
-constexpr unsigned kMaxTMALastdimByte = 128;
#define GET_ATTRDEF_CLASSES
#include "mlir/Dialect/NVGPU/IR/NVGPUAttrDefs.h.inc"
|
|
#153451 In this PR, I forgot to remove kMaxTMALastdimByte. Sorry. |
durga4github
approved these changes
Aug 28, 2025
grypp
reviewed
Aug 28, 2025
| @@ -46,8 +46,6 @@ constexpr unsigned kMaxTMATensorDimension = 5; | |||
| /// to be traversed along each of the kMaxTMATensorDimension (tensorRank) | |||
| /// dimensions, must be non-zero and less than or equal to 256. | |||
| constexpr unsigned kMaxTMADimension = 256; | |||
| /// Last dimension of 2D+ TMA must be 128 bytes | |||
| constexpr unsigned kMaxTMALastdimByte = 128; | |||
There was a problem hiding this comment.
can you make it 16 and use it in the code
There was a problem hiding this comment.
To be honest, I don't quite understand your intention.
There was a problem hiding this comment.
do this
/// Last dimension of 2D+ TMA must be 128 bytes
constexpr unsigned kMaxTMALastdimByte = 16;
int lastDimBytes =
descMemref.getShape().back() * descMemref.getElementTypeBitWidth() / 8;
if (lastDimBytes % kMaxTMALastdimByte != 0) {
return op->emitError() << "the bytes in the last dimension of the tensor "
"map must be a multiple of 16";
}
|
#152160 This PR must have forgotten to remove the unused variables. I pasted the wrong link above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the size of the last dimension of TMA is no longer fixed at 128 bytes, remove the kMaxTMALastdimByte.