[libc] Use intermediate float operations on the GPU #155869
Merged
+1
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Move the GPU config to the common directory instead of copying it and enable the intermediate float option in the math library.
|
@llvm/pr-subscribers-libc Author: Joseph Huber (jhuber6) ChangesSummary: Full diff: https://github.com/llvm/llvm-project/pull/155869.diff 2 Files Affected:
diff --git a/libc/config/gpu/amdgpu/config.json b/libc/config/gpu/config.json
similarity index 84%
rename from libc/config/gpu/amdgpu/config.json
rename to libc/config/gpu/config.json
index fa179b849dcf7..434ee042953eb 100644
--- a/libc/config/gpu/amdgpu/config.json
+++ b/libc/config/gpu/config.json
@@ -39,7 +39,7 @@
},
"math": {
"LIBC_CONF_MATH_OPTIMIZATIONS": {
- "value": "(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_SMALL_TABLES | LIBC_MATH_NO_ERRNO | LIBC_MATH_NO_EXCEPT)"
+ "value": "(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_INTERMEDIATE_COMP_IN_FLOAT | LIBC_MATH_SMALL_TABLES | LIBC_MATH_NO_ERRNO | LIBC_MATH_NO_EXCEPT)"
}
}
}
diff --git a/libc/config/gpu/nvptx/config.json b/libc/config/gpu/nvptx/config.json
deleted file mode 100644
index fa179b849dcf7..0000000000000
--- a/libc/config/gpu/nvptx/config.json
+++ /dev/null
@@ -1,45 +0,0 @@
-{
- "errno": {
- "LIBC_CONF_ERRNO_MODE": {
- "value": "LIBC_ERRNO_MODE_SHARED"
- }
- },
- "threads": {
- "LIBC_CONF_THREAD_MODE": {
- "value": "LIBC_THREAD_MODE_SINGLE"
- }
- },
- "printf": {
- "LIBC_CONF_PRINTF_DISABLE_FLOAT": {
- "value": true
- },
- "LIBC_CONF_PRINTF_DISABLE_INDEX_MODE": {
- "value": true
- },
- "LIBC_CONF_PRINTF_DISABLE_WRITE_INT": {
- "value": true
- },
- "LIBC_CONF_PRINTF_FLOAT_TO_STR_USE_MEGA_LONG_DOUBLE_TABLE": {
- "value": false
- },
- "LIBC_CONF_PRINTF_DISABLE_STRERROR": {
- "value": true
- },
- "LIBC_CONF_PRINTF_RUNTIME_DISPATCH": {
- "value": false
- }
- },
- "scanf": {
- "LIBC_CONF_SCANF_DISABLE_FLOAT": {
- "value": true
- },
- "LIBC_CONF_SCANF_DISABLE_INDEX_MODE": {
- "value": true
- }
- },
- "math": {
- "LIBC_CONF_MATH_OPTIMIZATIONS": {
- "value": "(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_SMALL_TABLES | LIBC_MATH_NO_ERRNO | LIBC_MATH_NO_EXCEPT)"
- }
- }
-}
|
lntue
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Move the GPU config to the common directory instead of copying it and
enable the intermediate float option in the math library.