[libc][test] Remove unused nan variables #155894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-libc Author: Jordan Rupprecht (rupprecht) ChangesThese are redefined/shadowed by the Added by #155569 Full diff: https://github.com/llvm/llvm-project/pull/155894.diff 1 Files Affected:
diff --git a/libc/test/src/math/smoke/TotalOrderTest.h b/libc/test/src/math/smoke/TotalOrderTest.h
index febed0157a6b2..50aac202f2028 100644
--- a/libc/test/src/math/smoke/TotalOrderTest.h
+++ b/libc/test/src/math/smoke/TotalOrderTest.h
@@ -104,12 +104,6 @@ class TotalOrderTestTemplate : public LIBC_NAMESPACE::testing::FEnvSafeTest {
}
void testNaNPayloads(TotalOrderFunc func) {
-
- T qnan_0x15 = FPBits::quiet_nan(Sign::POS, 0x15).get_val();
- T neg_qnan_0x15 = FPBits::quiet_nan(Sign::NEG, 0x15).get_val();
- T snan_0x15 = FPBits::signaling_nan(Sign::POS, 0x15).get_val();
- T neg_snan_0x15 = FPBits::signaling_nan(Sign::NEG, 0x15).get_val();
-
EXPECT_TRUE(funcWrapper(func, aNaN, aNaN));
EXPECT_TRUE(funcWrapper(func, sNaN, sNaN));
|
lntue
approved these changes
Aug 28, 2025
rupprecht
added a commit
that referenced
this pull request
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are redefined/shadowed by the
if constexpr (FPBits::FRACTION_LEN - 1 >= 5)case below.Added by #155569