[NFC] Fix warning in IR2Vec Embedder creation in printer pass #155917
+1
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-analysis Author: S. VenkataKeerthy (svkeerthy) ChangesFixes the warning Full diff: https://github.com/llvm/llvm-project/pull/155917.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/IR2Vec.cpp b/llvm/lib/Analysis/IR2Vec.cpp
index 7d0ad6a69a398..af6242d72e1c9 100644
--- a/llvm/lib/Analysis/IR2Vec.cpp
+++ b/llvm/lib/Analysis/IR2Vec.cpp
@@ -601,17 +601,7 @@ PreservedAnalyses IR2VecPrinterPass::run(Module &M,
assert(Vocabulary.isValid() && "IR2Vec Vocabulary is invalid");
for (Function &F : M) {
- std::unique_ptr<Embedder> Emb;
- switch (IR2VecEmbeddingKind) {
- case IR2VecKind::Symbolic:
- Emb = std::make_unique<SymbolicEmbedder>(F, Vocabulary);
- break;
- case IR2VecKind::FlowAware:
- Emb = std::make_unique<FlowAwareEmbedder>(F, Vocabulary);
- break;
- default:
- llvm_unreachable("Unknown IR2Vec embedding kind");
- }
+ auto Emb = Embedder::create(IR2VecEmbeddingKind, F, Vocabulary);
if (!Emb) {
OS << "Error creating IR2Vec embeddings \n";
continue;
|
|
@llvm/pr-subscribers-mlgo Author: S. VenkataKeerthy (svkeerthy) ChangesFixes the warning Full diff: https://github.com/llvm/llvm-project/pull/155917.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/IR2Vec.cpp b/llvm/lib/Analysis/IR2Vec.cpp
index 7d0ad6a69a398..af6242d72e1c9 100644
--- a/llvm/lib/Analysis/IR2Vec.cpp
+++ b/llvm/lib/Analysis/IR2Vec.cpp
@@ -601,17 +601,7 @@ PreservedAnalyses IR2VecPrinterPass::run(Module &M,
assert(Vocabulary.isValid() && "IR2Vec Vocabulary is invalid");
for (Function &F : M) {
- std::unique_ptr<Embedder> Emb;
- switch (IR2VecEmbeddingKind) {
- case IR2VecKind::Symbolic:
- Emb = std::make_unique<SymbolicEmbedder>(F, Vocabulary);
- break;
- case IR2VecKind::FlowAware:
- Emb = std::make_unique<FlowAwareEmbedder>(F, Vocabulary);
- break;
- default:
- llvm_unreachable("Unknown IR2Vec embedding kind");
- }
+ auto Emb = Embedder::create(IR2VecEmbeddingKind, F, Vocabulary);
if (!Emb) {
OS << "Error creating IR2Vec embeddings \n";
continue;
|
farzonl
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the warning
default label in switch which covers all enumeration values [-Wcovered-switch-default]