Reland "[lit] Refactor available ptxas features""
#155923
Draft
+370
−311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 826780a.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ptxas feature detection system in LLVM's lit testing framework to move from CUDA toolkit version-based checks to more granular ISA version and architecture-specific checks. This enables more precise testing by checking for specific SM architectures and PTX ISA versions that ptxas supports.
Key changes include:
- Refactored ptxas version detection and feature availability functions
- Updated test files to use new granular feature checks (
ptxas-sm_XX,ptxas-isa-X.Y,ptxas-ptr32) - Replaced broad version checks with specific capability-based checks
Reviewed Changes
Copilot reviewed 175 out of 175 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| llvm/test/lit.cfg.py | Completely refactored ptxas feature detection with new functions for ISA versions, SM architectures, and address size support |
| Various .ll/.py test files | Updated from version-based ptxas checks to granular feature-based checks using new ptxas-sm_XX and ptxas-isa-X.Y patterns |
Comments suppressed due to low confidence (3)
|
For reference: #155912 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #154439. Reverted with #155914.
Account for:
ptxasoutputting error messages tostdoutinstead ofstderrllvm/test/DebugInfo/NVPTX