[LLVM] Add support to define lit test suites with a smaller set of dependencies #155929
+109
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshockwave
reviewed
Aug 28, 2025
| @@ -2192,13 +2192,39 @@ endfunction() | |||
|
|
|||
| function(add_lit_testsuites project directory) | |||
| if (NOT LLVM_ENABLE_IDE) | |||
| cmake_parse_arguments(ARG "EXCLUDE_FROM_CHECK_ALL" "FOLDER;BINARY_DIR" "PARAMS;DEPENDS;ARGS" ${ARGN}) | |||
| cmake_parse_arguments(ARG "EXCLUDE_FROM_CHECK_ALL" "FOLDER;BINARY_DIR" | |||
| "PARAMS;DEPENDS;ARGS;EXCLUDE_DIR;INCLUDE_DIR" ${ARGN}) | |||
There was a problem hiding this comment.
could you use EXCLUDE_DIRS that takes a list of folders instead (similar suggestion for INCLUDE_DIR)? CMake's separate_arguments could help you to split a list of space-separate arguments into semicolon-separated ones.
|
I'm confused by the title, shouldn't it be instead "Add support to define lit test suites with an include/exclude list of folders" or something like this? I don't see the "dependency" part here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
add_lit_testsuitesto accept either a set of include or a set of exclude directories and use that to specializecheck-llvm-tablegenandcheck-llvm-filechecktargets to use a trimmed down set of dependencies. Thecheck-llvm-filechecktrimming is just for demonstration purpose to show how > 1 testsuites can have smaller set of dependencies than the defaultLLVM_TEST_DEPENDS.Note that building
check-llvm-filecheckfor example when not all LLVM tools have been built results in warnings like:but the lit tests run fine since all the dependencies specified do get rebuilt.