[compiler-rt] Make __EH_FRAME_LIST__ const to avoid RW .eh_frame mapping (#155764) #155955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing (llvm#155764) In crtbegin.c, __EH_FRAME_LIST__ was previously declared as a writable array of pointers. This caused the linker to place .eh_frame into a segment with read-write permissions, leading to larger virtual memory footprint at runtime (e.g. .eh_frame mapped into both LOAD and RELRO). Changing it to `static void * const __EH_FRAME_LIST__[]` ensures that the section is treated as read-only, matching GCC’s behavior with __EH_FRAME_BEGIN__. This prevents unnecessary RW mappings of .eh_frame while preserving the intended semantics.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Update crtbegin.c format
MaskRay
approved these changes
Aug 30, 2025
|
thanks @MaskRay |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/14548 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In crtbegin.c,
__EH_FRAME_LIST__was previously declared as a writable array of pointers. This caused the linker to place .eh_frame into a segment with read-write permissions, leading to larger virtual memory footprint at runtime (e.g. .eh_frame mapped into both LOAD and RELRO).Changing it to
static void * const __EH_FRAME_LIST__[]ensures that the section is treated as read-only, matching GCC’s behavior with__EH_FRAME_BEGIN__. This prevents unnecessary RW mappings of .eh_frame while preserving the intended semantics.Fixes: #155764