[ADT] Delegate to DenseMap::find_as (NFC) #155974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenseMap::find is a special case of DenseMap::find_as with a restriction on the key type.
|
@llvm/pr-subscribers-llvm-adt Author: Kazu Hirata (kazutakahirata) ChangesDenseMap::find is a special case of DenseMap::find_as with a Full diff: https://github.com/llvm/llvm-project/pull/155974.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/DenseMap.h b/llvm/include/llvm/ADT/DenseMap.h
index c44706a597fa6..3e59f843e0bee 100644
--- a/llvm/include/llvm/ADT/DenseMap.h
+++ b/llvm/include/llvm/ADT/DenseMap.h
@@ -174,20 +174,8 @@ class DenseMapBase : public DebugEpochBase {
return contains(Val) ? 1 : 0;
}
- iterator find(const_arg_type_t<KeyT> Val) {
- if (BucketT *Bucket = doFind(Val))
- return makeIterator(
- Bucket, shouldReverseIterate<KeyT>() ? getBuckets() : getBucketsEnd(),
- *this, true);
- return end();
- }
- const_iterator find(const_arg_type_t<KeyT> Val) const {
- if (const BucketT *Bucket = doFind(Val))
- return makeConstIterator(
- Bucket, shouldReverseIterate<KeyT>() ? getBuckets() : getBucketsEnd(),
- *this, true);
- return end();
- }
+ iterator find(const_arg_type_t<KeyT> Val) { return find_as(Val); }
+ const_iterator find(const_arg_type_t<KeyT> Val) const { return find_as(Val); }
/// Alternate version of find() which allows a different, and possibly
/// less expensive, key type.
|
arsenm
approved these changes
Aug 29, 2025
kuhar
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DenseMap::find is a special case of DenseMap::find_as with a
restriction on the key type.