Skip to content

Re-create venv for dev release publish #12725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Conversation

silv-io
Copy link
Member

@silv-io silv-io commented Jun 6, 2025

Motivation

In CircleCI we pass the workspace through and have an existing venv ready which we can activate. This is not the case in GitHub Actions so we need to re-create the venv with the make publish target.

Changes

  • remove .venv activation in dev release
  • install basic version of localstack for building the dist

Copy link

github-actions bot commented Jun 6, 2025

Test Results - Preflight, Unit

21 595 tests  ±0   19 940 ✅ ±0   6m 16s ⏱️ -1s
     1 suites ±0    1 655 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit a9912f0. ± Comparison against base commit 2128c6a.

Copy link

github-actions bot commented Jun 6, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 9s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit a9912f0. ± Comparison against base commit 2128c6a.

Copy link

github-actions bot commented Jun 6, 2025

Test Results - Alternative Providers

987 tests   574 ✅  22m 58s ⏱️
  4 suites  413 💤
  4 files      0 ❌

Results for commit a9912f0.

@silv-io silv-io added the semver: patch Non-breaking changes which can be included in patch releases label Jun 6, 2025
@silv-io silv-io merged commit 36f5b6d into master Jun 6, 2025
5 of 6 checks passed
@silv-io silv-io deleted the fix-dev-release-publishing branch June 6, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants