Skip to content

APIGW: add IntegrationResponse test and fix UpdateIntegrationResponse #12743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2025
Merged

APIGW: add IntegrationResponse test and fix UpdateIntegrationResponse #12743

merged 5 commits into from
Jun 11, 2025

Conversation

ArthurAkh
Copy link
Contributor

Motivation

Adding lifecycle test coverage for the IntegrationResponse resource in API Gateway v1.

Changes

Adding a "test_lifecycle_integration_response", and adding a small fix in provider.py.

@localstack-bot
Copy link
Collaborator

localstack-bot commented Jun 11, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ArthurAkh
Copy link
Contributor Author

ArthurAkh commented Jun 11, 2025 •
edited by bentsku
Loading

I have read the CLA Document and I hereby sign the CLA

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 613 tests  ±0   19 958 ✅ ±0   6m 17s ⏱️ +6s
     1 suites ±0    1 655 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 3932483. ± Comparison against base commit 75c84f6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   18m 23s ⏱️ - 1h 24m 29s
1 136 tests  - 3 736  1 071 ✅  - 3 024  65 💤  - 712  0 ❌ ±0 
1 138 runs   - 3 736  1 071 ✅  - 3 024  67 💤  - 712  0 ❌ ±0 

Results for commit 3932483. ± Comparison against base commit 75c84f6.

This pull request removes 3737 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.apigateway.test_apigateway_api.TestApigatewayIntegration ‑ test_lifecycle_integration_response

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 3932483. ± Comparison against base commit 75c84f6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   36m 51s ⏱️
1 160 tests 1 095 ✅ 65 💤 0 ❌
1 166 runs  1 095 ✅ 71 💤 0 ❌

Results for commit 3932483.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

Test Results - Alternative Providers

987 tests   585 ✅  29m 8s ⏱️
  4 suites  402 💤
  4 files      0 ❌

Results for commit 3932483.

♻️ This comment has been updated with latest results.

@ArthurAkh ArthurAkh added the semver: patch Non-breaking changes which can be included in patch releases label Jun 11, 2025
@ArthurAkh
Copy link
Contributor Author

recheck

localstack-bot added a commit that referenced this pull request Jun 11, 2025
@localstack-bot
@ArthurAkh has signed the CLA in #12743
9924c79
bentsku
bentsku approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a great addition, and this is really nice there's also a fix to have better parity for the UpdateIntegrationResponse API operation as it now returns the proper values, and also support selectionPattern! 🚀

I only have a small comment but it is only formatting and this is not blocking, you can update it if you'd like 😄

Welcome to the list of LocalStack's contributors! 🚀

@ArthurAkh @bentsku
Update localstack-core/localstack/services/apigateway/legacy/provider.py
72e731f 
Co-authored-by: Ben Simon Hartung <42031100+bentsku@users.noreply.github.com>
@bentsku bentsku changed the title Apigw integrationresponse tests APIGW: add IntegrationResponse test and fix UpdateIntegrationResponse Jun 11, 2025
@ArthurAkh ArthurAkh merged commit 3a2f014 into master Jun 11, 2025
15 checks passed
@ArthurAkh ArthurAkh deleted the apigw-integrationresponse-tests branch June 11, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku approved these changes

@cloutierMat cloutierMat Awaiting requested review from cloutierMat cloutierMat is a code owner

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArthurAkh @localstack-bot @bentsku