Skip to content

CFNv2: validate stack sets test #12920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

CFNv2: validate stack sets test #12920

wants to merge 2 commits into from
+207 −5

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Jul 28, 2025

Motivation

With #12909 we introduced stack set support, however the test was not enough and did not actually test the resources in the stack instances were actually created.

I originally didn't think this was possible and required manual setup, however in a classic shower thought I realised I could ensure the "manual" setup could be done via a CFn template.

Changes

  • Validate the stack instance resources are created both via an API snapshot and through service level operations
  • Introduce a pre-deploy setup step that ensures the correct administration and execution roles are present

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Jul 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 991 tests  ±0   20 257 ✅ ±0   6m 19s ⏱️ -8s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 125103f. ± Comparison against base commit fb42a08.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 46m 35s ⏱️ - 1m 51s
4 942 tests ±0  4 169 ✅ ±0  773 💤 ±0  0 ❌ ±0 
4 944 runs  ±0  4 169 ✅ ±0  775 💤 ±0  0 ❌ ±0 

Results for commit 125103f. ± Comparison against base commit fb42a08.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed added this to the 4.8 milestone Jul 29, 2025
Base automatically changed from cfn/v2/stack-sets to main July 29, 2025 13:39
@simonrw simonrw force-pushed the cfn/v2/validated-stack-sets branch from b97c752 to 125103f Compare July 29, 2025 13:44
@github-actions GitHub Actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 15s ⏱️ +6s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 125103f. ± Comparison against base commit fb42a08.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 20m 29s ⏱️
4 841 tests 4 361 ✅ 480 💤 0 ❌
4 847 runs  4 361 ✅ 486 💤 0 ❌

Results for commit 125103f.

@coveralls
Copy link

Coverage Status

coverage: 85.925% (+34.5%) from 51.377%
when pulling 125103f on cfn/v2/validated-stack-sets
into fb42a08 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon Awaiting requested review from pinzon pinzon will be requested when the pull request is marked ready for review pinzon is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert will be requested when the pull request is marked ready for review dominikschubert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.
3 participants
@simonrw @coveralls @alexrashed