Improve remove docker container function to take into account stopped containers #12979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrisDary
approved these changes
Aug 8, 2025
alexrashed
reviewed
Aug 12, 2025
There was a problem hiding this comment.
suggestion: This module is incredibly important and well-tested, and we basically try to have tests for every change whenever possible. Could you please add a test for this edge case to the test for this module?
The tests are done in this class here:
When adding a new test, it will automatically be executed for both - the SDK and the CMD client. :)
dfangl
reviewed
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, this remove container method doesn't take into account stopped containers when you ask it to check for existence of it
Related PR for more context about why bother with this change -> https://github.com/localstack/localstack-pro/pull/5037
Changes
get_all_container_names) I didn't touch the old method (get_running_container_names) to keep compatibility and not break any code already using it.