Skip to content

CFNV2: Minor parity changes #12982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 11, 2025
Merged

CFNV2: Minor parity changes #12982

merged 8 commits into from
Aug 11, 2025

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Aug 9, 2025 •
edited
Loading

Motivation

This PR reflects a few minor fixes I found while tackling the outstanding skipped tests. Sorry there is not more of a coherent theme.

Note: this PR's base branch is not main, as it builds on another PR with additional changes (#12980).

Changes

  • Move some base types to their own module to prevent import cycles
  • Model DeletionPolicy and UpdateReplacementPolicy for resources and include them in the change assessment
  • Extract engine_parameter_value which takes the (non-resolved) value
  • Propagates the stack description
  • Build mapping of after parameters and extract method
  • Set the processed template of the stack after create_stack
  • Improve test_update_with_previous_parameter_value to be more rigorous

@simonrw simonrw added this to the 4.8 milestone Aug 9, 2025
@simonrw simonrw added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 063 tests  ±0   20 329 ✅ ±0   6m 34s ⏱️ +5s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 159adab. ± Comparison against base commit 0c6bb6d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±0    2 suites  ±0   21m 30s ⏱️ -52s
554 tests ±0  329 ✅ ±0  225 💤 ±0  0 ❌ ±0 
556 runs  ±0  329 ✅ ±0  227 💤 ±0  0 ❌ ±0 

Results for commit 159adab. ± Comparison against base commit 0c6bb6d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 11s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 159adab. ± Comparison against base commit 0c6bb6d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files  ±0    5 suites  ±0   33m 52s ⏱️ +28s
578 tests ±0  354 ✅ ±0  224 💤 ±0  0 ❌ ±0 
584 runs  ±0  354 ✅ ±0  230 💤 ±0  0 ❌ ±0 

Results for commit 159adab. ± Comparison against base commit 0c6bb6d.

♻️ This comment has been updated with latest results.

@simonrw simonrw force-pushed the cfn/v2/minor-parity-changes branch from 57a3b70 to 9f9a1fa Compare August 9, 2025 14:46
@simonrw simonrw marked this pull request as ready for review August 9, 2025 20:59
pinzon
pinzon approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I'm a bit conflicted on creating a new file just for 2 type definitions but doesn't seem too bad.

@simonrw simonrw merged commit a4a7199 into cfn/v2/describing Aug 11, 2025
40 checks passed
@simonrw simonrw deleted the cfn/v2/minor-parity-changes branch August 11, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees
No one assigned
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrw @pinzon