Skip to content

CFNV2: Unskip remaining Resolve tests #12997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 15, 2025
Merged

CFNV2: Unskip remaining Resolve tests #12997

merged 16 commits into from
Aug 15, 2025

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Aug 12, 2025 •
edited
Loading

Motivation

We have some currently skipped tests relating to "Resolve". We should have mainly implemented resolving with #12934 so these remaining test skips should be relatively minor.

Changes

  • Extract helper function for rendering EngineParameters
  • Handle comma delimited lists for SSM parameter parameters using a regex to match whether they are a list type or not, or otherwise treat them as a string
  • Unskip more tests

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Aug 12, 2025
@simonrw simonrw changed the base branch from main to cfn/v2/reporting August 12, 2025 13:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 107 tests  ±0   20 372 ✅ ±0   6m 25s ⏱️ +6s
     1 suites ±0    1 735 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 9c7fd42. ± Comparison against base commit c417544.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files    2 suites   22m 3s ⏱️
555 tests 330 ✅ 225 💤 0 ❌
557 runs  330 ✅ 227 💤 0 ❌

Results for commit 9c7fd42.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 17s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 9c7fd42. ± Comparison against base commit c417544.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   33m 35s ⏱️
579 tests 355 ✅ 224 💤 0 ❌
585 runs  355 ✅ 230 💤 0 ❌

Results for commit 9c7fd42.

♻️ This comment has been updated with latest results.

Base automatically changed from cfn/v2/reporting to main August 12, 2025 17:21
@simonrw simonrw marked this pull request as ready for review August 12, 2025 21:42
pinzon
pinzon approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@simonrw simonrw merged commit 976f3a4 into main Aug 15, 2025
40 checks passed
@simonrw simonrw deleted the cfn/v2/resolve-2 branch August 15, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrw @pinzon