Migrate from jpype1-ext to jpype1 #13005
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 7m 57s ⏱️ Results for commit 6cb8032. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 24s ⏱️ Results for commit 6cb8032. |
alexrashed
approved these changes
Aug 14, 2025
|
Just did some manual testing and SIGTERM handling works as expected 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the addition of jpype1 last year, we had the issue that jpype would not pass control back to the python process on SIGTERM, but only on SIGINT.
This lead to issues with shutdown, which we fixed in our fork
jpype1-ext. However, we have since contributed this fix upstream, and jpype1 1.6.0 should have this fix in by default, which was released recently.With the effort to use python 3.13 as well, this provides a good opportunity to switch back, as
jpype1provides wheels for python3.13, whilejpype1-extcurrently does not (it would be fairly easy to add, but unnecessary as we want to deprecate the fork anyway).Changes
jpype1-exttojpypemake upgrade-pinned-dependencies