Skip to content

CFNV2: finish URL replacements for API Gateway #13012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: cfn/v2/implement-no-echo
Choose a base branch
from
Open

CFNV2: finish URL replacements for API Gateway #13012

wants to merge 2 commits into from

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Aug 15, 2025

Motivation

One remaining case where we replace API Gateway urls with LocalStack URLs remains.

Note: this is needed for APIGWv1 because the URL is not an output of the API so we have to adjust it in CFn :(

Note

This forms a stack on top of #13011

Changes

  • Handle URL replacements in Join and Sub

@simonrw simonrw added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases review: merge when ready Signals to the reviewer that a PR can be merged if accepted labels Aug 15, 2025
@simonrw simonrw added this to the 4.8 milestone Aug 15, 2025
@simonrw simonrw changed the title Cfn/v2/url replacements CFNV2: finish URL replacements for API Gateway Aug 15, 2025
@github-actions GitHub Actions
Copy link

Test Results - Preflight, Unit

22 107 tests  ±0   20 372 ✅ ±0   6m 14s ⏱️ -19s
     1 suites ±0    1 735 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 5ab71be. ± Comparison against base commit ca51a61.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

  2 files  ±0    2 suites  ±0   22m 27s ⏱️ +12s
555 tests ±0  330 ✅ ±0  225 💤 ±0  0 ❌ ±0 
557 runs  ±0  330 ✅ ±0  227 💤 ±0  0 ❌ ±0 

Results for commit 5ab71be. ± Comparison against base commit ca51a61.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 9s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 5ab71be. ± Comparison against base commit ca51a61.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Integration, Bootstrap

  5 files  ±0    5 suites  ±0   33m 34s ⏱️ -48s
579 tests ±0  355 ✅ ±0  224 💤 ±0  0 ❌ ±0 
585 runs  ±0  355 ✅ ±0  230 💤 ±0  0 ❌ ±0 

Results for commit 5ab71be. ± Comparison against base commit ca51a61.

@simonrw simonrw marked this pull request as ready for review August 15, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

@pinzon pinzon

Labels
review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrw @pinzon