Skip to content

CFNV2: provide logging for deferred actions and cleanup #13018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: cfn/v2/url-replacements
Choose a base branch
from

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Aug 18, 2025

Motivation

While debugging I found it useful to log the deffered actions as they happen along with why the action was being run.

There are also some tests that now pass that haven't been unskipped.

Note

This PR is part of a stack and builds on #13012

Changes

  • Allow the logging of deferred actions at DEBUG level
  • Override select in the describer to propagate known after apply status if the index cannot be accessed
  • unskip three more tests 🎉

@simonrw simonrw added this to the 4.8 milestone Aug 18, 2025
@simonrw simonrw added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 18, 2025
Copy link

github-actions bot commented Aug 18, 2025

Test Results - Preflight, Unit

22 107 tests  ±0   20 372 ✅ ±0   6m 33s ⏱️ +19s
     1 suites ±0    1 735 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 34df121. ± Comparison against base commit 5ab71be.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 18, 2025

LocalStack Community integration with Pro

  2 files  ±0    2 suites  ±0   21m 18s ⏱️ - 1m 9s
555 tests ±0  330 ✅ ±0  225 💤 ±0  0 ❌ ±0 
557 runs  ±0  330 ✅ ±0  227 💤 ±0  0 ❌ ±0 

Results for commit 34df121. ± Comparison against base commit 5ab71be.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 18, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 34df121. ± Comparison against base commit 5ab71be.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 18, 2025

Test Results (amd64) - Integration, Bootstrap

  5 files  ±0    5 suites  ±0   33m 37s ⏱️ +3s
579 tests ±0  355 ✅ ±0  224 💤 ±0  0 ❌ ±0 
585 runs  ±0  355 ✅ ±0  230 💤 ±0  0 ❌ ±0 

Results for commit 34df121. ± Comparison against base commit 5ab71be.

♻️ This comment has been updated with latest results.

@simonrw simonrw marked this pull request as ready for review August 18, 2025 19:18
@simonrw simonrw added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Aug 19, 2025
@simonrw simonrw assigned simonrw and pinzon and unassigned simonrw Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants