Skip to content

Re-enable C416 ruff rule #13025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

Re-enable C416 ruff rule #13025

merged 2 commits into from
Aug 19, 2025

Conversation

giograno
Copy link
Member

@giograno giograno commented Aug 19, 2025

Motivation

Following up on our efforts for a better linting (see #12953 and following PRs), this PR re-enables the rule C416 and adjusts the code to be compliant.

Our Pro codebase already re-enabled this rule.

@giograno giograno self-assigned this Aug 19, 2025
@giograno giograno added the semver: patch Non-breaking changes which can be included in patch releases label Aug 19, 2025
Copy link

S3 Image Test Results (AMD64 / ARM64)

    2 files    2 suites   7m 52s ⏱️
  515 tests 465 ✅  50 💤 0 ❌
1 030 runs  930 ✅ 100 💤 0 ❌

Results for commit a31ad90.

Copy link

Test Results - Preflight, Unit

22 139 tests  ±0   20 404 ✅ ±0   6m 22s ⏱️ -9s
     1 suites ±0    1 735 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit a31ad90. ± Comparison against base commit 1baa022.

Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 9s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit a31ad90. ± Comparison against base commit 1baa022.

Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 20m 17s ⏱️
4 989 tests 4 397 ✅ 592 💤 0 ❌
4 995 runs  4 397 ✅ 598 💤 0 ❌

Results for commit a31ad90.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 44m 2s ⏱️ + 1m 31s
4 630 tests ±0  4 190 ✅ ±0  440 💤 ±0  0 ❌ ±0 
4 632 runs  ±0  4 190 ✅ ±0  442 💤 ±0  0 ❌ ±0 

Results for commit a31ad90. ± Comparison against base commit 1baa022.

@giograno giograno removed the request for review from bentsku August 19, 2025 12:56
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@giograno giograno merged commit 1d26825 into main Aug 19, 2025
56 checks passed
@giograno giograno deleted the C416 branch August 19, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants