IaC: AWS and CloudFormation features support catalog #13026
Conversation
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 2s ⏱️ Results for commit 8b3c93d. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
edit: oops, sent without the full message 😅
This is great, thanks for adding this! It will be easier to iterate over it collectively 🚀
I think it would be good to add a CODEOWNERS entry for this module back to our squad, so it'd be easier for review 👍
I only have a comment around the factory of the class, in order to extend it from Pro and allow us to transparently modify behavior of the callers of the class
| @staticmethod | ||
| @singleton_factory | ||
| def get() -> "AwsServicesCatalog": | ||
| return AwsServicesCatalog() |
There was a problem hiding this comment.
nit: I commented on the wrong PR, but I think this might be better encapsulated in a factory function outside of the class, so it'd be easier to change the factory behavior to return a different class. Here, we're stuck with AwsServicesCatalog with maybe no way to extend it from Pro
Sorry, this might have been my suggestion 😕
There was a problem hiding this comment.
no problem, good point :)
Motivation
Create initial structure for AWS and CloudFormation catalogs.
Changes
AwsServicesCatalogandCloudFormationCatalog