Skip to content

Ruff linter: enable rule UP028 #13048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

Ruff linter: enable rule UP028 #13048

merged 2 commits into from
Aug 26, 2025
+7 −15

Conversation

giograno
Copy link
Member

@giograno giograno commented Aug 22, 2025 •
edited
Loading

Motivation

#12953 introduced the pyupgrade rules to our ruff linter.
However, a few rules have been ignored. This PR enabled UP028 and fixes the code accordingly.

@giograno giograno added this to the Playground milestone Aug 22, 2025
@giograno giograno self-assigned this Aug 22, 2025
@giograno giograno added semver: patch Non-breaking changes which can be included in patch releases skip-docs Pull request does not require documentation changes labels Aug 22, 2025
@github-actions GitHub Actions
Copy link

Test Results - Preflight, Unit

22 144 tests  ±0   20 407 ✅ ±0   6m 37s ⏱️ +11s
     1 suites ±0    1 737 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 4fe3ac1. ± Comparison against base commit 047b419.

@giograno giograno changed the title Fix Ruff linter: enable rule UP028 Ruff linter: enable rule UP028 Aug 22, 2025
@github-actions GitHub Actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 8s ⏱️ -3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 4fe3ac1. ± Comparison against base commit 047b419.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 20m 39s ⏱️
5 003 tests 4 403 ✅ 600 💤 0 ❌
5 009 runs  4 403 ✅ 606 💤 0 ❌

Results for commit 4fe3ac1.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 42m 46s ⏱️ - 2m 12s
4 632 tests ±0  4 190 ✅ ±0  442 💤 ±0  0 ❌ ±0 
4 634 runs  ±0  4 190 ✅ ±0  444 💤 ±0  0 ❌ ±0 

Results for commit 4fe3ac1. ± Comparison against base commit 047b419.

@giograno giograno marked this pull request as ready for review August 22, 2025 16:44
alexrashed
alexrashed approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, small, and clean! Thanks for churning over the rule exclusions! 💯

@giograno giograno merged commit 0412d0f into main Aug 26, 2025
14 of 15 checks passed
@giograno giograno deleted the fix-up028 branch August 26, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@bentsku bentsku Awaiting requested review from bentsku bentsku is a code owner

Assignees

@giograno giograno

Labels
semver: patch Non-breaking changes which can be included in patch releases skip-docs Pull request does not require documentation changes
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
2 participants
@giograno @alexrashed