Skip to content

Fix SQS tests failing due to missing snapshot update after #12957 #13062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

Fix SQS tests failing due to missing snapshot update after #12957 #13062

merged 1 commit into from
Aug 27, 2025

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Aug 27, 2025

Motivation

With #12957, the SQS maximum message size was changed to 1 MiB.
However, some snapshots were missed due to the test selection not taking into account cloudformation tests, which fails our pipelines.

Changes

  • Update snapshots for failing SQS cloudformation tests

@dfangl dfangl requested a review from simonrw as a code owner August 27, 2025 09:42
@dfangl dfangl added this to the 4.8 milestone Aug 27, 2025
@dfangl dfangl requested a review from pinzon as a code owner August 27, 2025 09:42
@dfangl dfangl added semver: patch Non-breaking changes which can be included in patch releases skip-docs Pull request does not require documentation changes labels Aug 27, 2025
@dfangl dfangl requested a review from alexrashed August 27, 2025 09:42
baermat
baermat approved these changes Aug 27, 2025
View reviewed changes
Copy link
Member

@baermat baermat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I was part of the initial sqs PR, I took the liberty of reviewing this :) Thanks for tackling this, LGTM!

@github-actions GitHub Actions
Copy link

Test Results - Preflight, Unit

22 159 tests  ±0   20 422 ✅ ±0   6m 26s ⏱️ +12s
     1 suites ±0    1 737 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 3e8298f. ± Comparison against base commit de861e1f.

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 8s ⏱️ -15s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 3e8298f. ± Comparison against base commit de861e1f.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   28m 8s ⏱️ - 1h 15m 17s
555 tests  - 4 077  328 ✅  - 3 858  227 💤  - 216  0 ❌  - 3 
557 runs   - 4 077  328 ✅  - 3 858  229 💤  - 216  0 ❌  - 3 

Results for commit 3e8298f. ± Comparison against base commit de861e1f.

This pull request removes 4077 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions GitHub Actions
Copy link

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   33m 52s ⏱️
579 tests 353 ✅ 226 💤 0 ❌
585 runs  353 ✅ 232 💤 0 ❌

Results for commit 3e8298f.

@dfangl dfangl merged commit 75c1298 into main Aug 27, 2025
47 checks passed
@dfangl dfangl deleted the sqs/fix-snapshots branch August 27, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baermat baermat baermat approved these changes

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@alexrashed alexrashed Awaiting requested review from alexrashed

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases skip-docs Pull request does not require documentation changes
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.
2 participants
@dfangl @baermat