Skip to content

CFNV2: fix community issues after attempted pro fixes #13101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 4, 2025
Merged

CFNV2: fix community issues after attempted pro fixes #13101

merged 4 commits into from
Sep 4, 2025

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Sep 4, 2025 •
edited
Loading

Motivation

While performing the last minute fixes for the Pro resources in #13045 we found that the v2 community tests were not being run. This meant that some bugs slipped in to the new provider undetected. This was only picked up in #13098.

Changes

  • Correct the test changes determination to include the service code as well as the tests
  • Undo a couple of fixes from add fixes to CFnV2 for pro pipeline #13045 that are no longer needed
  • Handle the case where during modelling try_load_resource_provider is called with a Nothing value

@simonrw simonrw added semver: patch Non-breaking changes which can be included in patch releases skip-docs Pull request does not require documentation changes labels Sep 4, 2025
@simonrw simonrw added this to the 4.8 milestone Sep 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

Test Results (MA/MR) - Preflight, Unit

22 117 tests   20 379 ✅  6m 36s ⏱️
     1 suites   1 738 💤
     1 files         0 ❌

Results for commit 9fe5707.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 117 tests   20 379 ✅  6m 31s ⏱️
     1 suites   1 738 💤
     1 files         0 ❌

Results for commit 9fe5707.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025

Test Results (amd64) - Acceptance

7 tests   5 ✅  3m 11s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 9fe5707.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025

Test Results (amd64, MA/MR) - Acceptance

7 tests   5 ✅  3m 4s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 9fe5707.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 42s ⏱️
5 010 tests 4 408 ✅ 602 💤 0 ❌
5 016 runs  4 408 ✅ 608 💤 0 ❌

Results for commit 9fe5707.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025

Test Results (amd64, MA/MR) - Integration, Bootstrap

    5 files      5 suites   2h 23m 26s ⏱️
5 010 tests 4 408 ✅ 602 💤 0 ❌
5 016 runs  4 408 ✅ 608 💤 0 ❌

Results for commit 9fe5707.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025

LocalStack Community integration with Pro

    2 files      2 suites   1h 43m 30s ⏱️
4 637 tests 4 194 ✅ 443 💤 0 ❌
4 639 runs  4 194 ✅ 445 💤 0 ❌

Results for commit 9fe5707.

@simonrw simonrw marked this pull request as ready for review September 4, 2025 19:56
@simonrw simonrw merged commit 9043813 into main Sep 4, 2025
70 checks passed
@simonrw simonrw deleted the cfn/v2/fix-community-tests branch September 4, 2025 20:05
@simonrw simonrw mentioned this pull request Sep 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@alexrashed alexrashed Awaiting requested review from alexrashed alexrashed is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@silv-io silv-io Awaiting requested review from silv-io silv-io is a code owner

@k-a-il k-a-il Awaiting requested review from k-a-il k-a-il is a code owner

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases skip-docs Pull request does not require documentation changes
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrw @pinzon