You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I encountered this issue when writing an EKS/CFn test during a deletion of Stack:
Traceback (most recent call last):
File "/home/cristopher/Work/ls_workspace/localstack-pro/.venv/lib/python3.11/site-packages/localstack_snapshot/snapshots/prototype.py", line 121, in _persist_state
state_to_dump = json.dumps(full_state, indent=2)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/cristopher/.pyenv/versions/3.11.12/lib/python3.11/json/__init__.py", line 238, in dumps
**kw).encode(obj)
^^^^^^^^^^^
File "/home/cristopher/.pyenv/versions/3.11.12/lib/python3.11/json/encoder.py", line 202, in encode
chunks = list(chunks)
^^^^^^^^^^^^
File "/home/cristopher/.pyenv/versions/3.11.12/lib/python3.11/json/encoder.py", line 432, in _iterencode
yield from _iterencode_dict(o, _current_indent_level)
File "/home/cristopher/.pyenv/versions/3.11.12/lib/python3.11/json/encoder.py", line 406, in _iterencode_dict
yield from chunks
File "/home/cristopher/.pyenv/versions/3.11.12/lib/python3.11/json/encoder.py", line 406, in _iterencode_dict
yield from chunks
File "/home/cristopher/.pyenv/versions/3.11.12/lib/python3.11/json/encoder.py", line 406, in _iterencode_dict
yield from chunks
[Previous line repeated 2 more times]
File "/home/cristopher/.pyenv/versions/3.11.12/lib/python3.11/json/encoder.py", line 439, in _iterencode
o = _default(o)
^^^^^^^^^^^
File "/home/cristopher/.pyenv/versions/3.11.12/lib/python3.11/json/encoder.py", line 180, in default
raise TypeError(f'Object of type {o.__class__.__name__} '
TypeError: Object of type datetime is not JSON serializable
So I fixed locally. Is there a particular reason the CustomJsonEncoder is not used in _persis_state?
Presumably this is post transformation, which implies we have missed transforming a datetime that we probably should, right? We should not let datetimes (even serialized ones) into our snapshots IMO
The _persist_raw operation uses the encoder. So it seems strange to me that the _persist_state doesn't use it.
Because the _persist_state method is called after transformation right? so values are transformed to be primitives (including datetimes which are not only transformed to strings to remove the need for a custom encoder, but to set their values to a known constant so we can compare the LocalStack implementation).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I encountered this issue when writing an EKS/CFn test during a deletion of Stack:
So I fixed locally. Is there a particular reason the CustomJsonEncoder is not used in
_persis_state?