Skip to content

Conversation

drstrangelooker
Copy link
Collaborator

…o dashboard elements (#818)

  • Pushing new_dashboard_filter to remote

  • Adding example to create_dashboard_filter, fixes 816

  • Rename dashboard_filter file

  • add new line at end of file

  • Fixing new line at end of file 🤦🏼‍♂️

  • Condensing loops

  • Consolidating loops, adding check for matching model and explore

  • Removing unnecessary loop

Co-authored-by: Kevin Dunn kevincdunn@google.com

Copy of #818

@drstrangelooker drstrangelooker force-pushed the example_of_creating_dashboard_filter branch from 0b750d6 to 1ecfe1b Compare February 15, 2022 22:32
@jeremytchang
Copy link
Collaborator

jeremytchang commented Feb 18, 2022

For the future, we should have contributors point their PRs to main and merge their PRs into main. Or else this leaves the change owner unaware of their changes going into main and clutters our commit history with co-authors.

…o dashboard elements (#818)

* Pushing new_dashboard_filter to remote

* Adding example to create_dashboard_filter, fixes 816

* Rename dashboard_filter file

* add new line at end of file

* Fixing new line at end of file 🤦🏼‍♂️

* Condensing loops

* Consolidating loops, adding check for matching model and explore

* Removing unnecessary loop

Co-authored-by: Kevin Dunn <kevincdunn@google.com>
@drstrangelooker drstrangelooker force-pushed the example_of_creating_dashboard_filter branch from 1ecfe1b to 3412dbc Compare February 23, 2022 01:25
@drstrangelooker drstrangelooker requested a review from a team as a code owner March 12, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants