Skip to content

Filter group members by role #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged

Filter group members by role #1874

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ff5f78
Dropdown in User Groups to filter roles
kamalqureshi Jul 16, 2025
7869f0b
Merge branch 'dev' into filter_group_members_role
kamalqureshi Jul 21, 2025
111ef6a
Updated useCallack to useMemo for optimization
kamalqureshi Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updated useCallack to useMemo for optimization
  • Loading branch information
@kamalqureshi
kamalqureshi committed Jul 21, 2025
commit 111ef6aa5c2a5251880884af4b64f02508bef718
9 changes: 3 additions & 6 deletions client/packages/lowcoder/src/pages/setting/permission/groupUsersPermission.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,7 @@ const GroupUsersPermission: React.FC<GroupPermissionProp> = (props) => {
});
}, [groupUsers]);

const roleFilterOptions = useCallback(() => {
const filterOptions = [
const roleFilterOptions = useMemo(() => [
...TacoRoles.map(role => ({
label: GroupRoleInfo[role].name,
value: role as RoleIdType | ""
Expand All @@ -110,9 +109,7 @@ const GroupUsersPermission: React.FC<GroupPermissionProp> = (props) => {
label: "All",
value: "" as RoleIdType | ""
}
]
return filterOptions;
}, [])
], []);

const debouncedFetchPotentialMembers = useCallback(
debounce((searchVal: string, roleFilter: string) => {
Expand Down Expand Up @@ -153,7 +150,7 @@ const GroupUsersPermission: React.FC<GroupPermissionProp> = (props) => {
{isGroupAdmin(currentUserGroupRole) && !group.syncGroup && (
<OptionsHeader>
<Dropdown
options={roleFilterOptions()}
options={roleFilterOptions}
value={roleFilter || ""}
onChange={(value) => {
setRoleFilter(value);
Expand Down
Loading