-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Align titles #22376 #25591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Align titles #22376 #25591
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d1067a6
Used previous pull request and now trying to figure out why savefigur…
AlextheGreat1509 e84960d
Fixed bbox issue not being updated when title position is changed.
SirSkillful d6d5d7f
Renamed align_titles to avoid confusion with the axis labels. Also re…
SirSkillful 065d992
Added tests from original pull request to test our solution
AlextheGreat1509 7f5220a
Changed test to try different way of accessing savefig function as cu…
AlextheGreat1509 838ace3
Updated code comments
AlextheGreat1509 9decc20
Refactoring of align_titles function
SirSkillful e8042f8
Merge branch 'matplotlib:main' into align_titles
AlextheGreat1509 52164fa
Fixed flake8 issues
AlextheGreat1509 b44fb00
Fixed flake8 issues
AlextheGreat1509 3741239
Fixed flake8 formating issues
SirSkillful 4eb53e6
Changed fix for savefig
SirSkillful 938d9e5
Merge remote-tracking branch 'origin/align_titles' into align_titles
AlextheGreat1509 1fe094a
Changed tests to use new styling standard. Titles now align as expect…
AlextheGreat1509 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failures that are directly related to this PR are due to the baseline images for this image comparison not being added to the repo
If it is passing locally, those two files (png, svg) should be added in the
baseline_images
folder