Skip to content

CI: Skip jobs on forks #30118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

CI: Skip jobs on forks #30118

merged 1 commit into from
Jun 4, 2025

Conversation

oscargus
Copy link
Member

PR summary

Tests are skipped when pushing changes to a fork, but some other jobs are run. Especially Build CI wheels is a bit unnecessary to run on forks. Also, the CodeQL job is executed periodically on forks, which may lead to emails, but if nothing else waste of compute resources.

PR checklist

@oscargus oscargus added CI: Run cibuildwheel Run wheel building tests on a PR CI: testing CI configuration and testing labels May 29, 2025
@tacaswell
Copy link
Member

Only downside is that if you want to use CI to check wheel buliding you must open a PR or remove the check, but I think that is a reasonable trade off to avoid burning the commute on every push (there is a reason we only do it on PRs in an opt-in basis).

@tacaswell tacaswell modified the milestones: v3.11.0, v3.10.4, v3.10-doc May 29, 2025
@tacaswell
Copy link
Member

and we might as well backport this to all of our active branches.

@oscargus
Copy link
Member Author

you must open a PR or remove the check

Although that wasn't part of the plan, I think that one can push the branch to the matplotlib repo to get that. Since the people with push access are the same that are most likely to do that, I think it should be manageable (although a bit of behavior change as most seems to use their private forks. Personally, I always open a PR anyway as I had not thought about the alternative...).

@oscargus
Copy link
Member Author

Btw, it seems like GitHub has disabled workflows on forks by default(?). Some recently cloned repos has a text that says that they are disabled. Makes sense.

GitHub Actions
Workflows aren’t being run on this forked repository
Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

Seems to have happened quite recently though.

(Or maybe there is some setting for the main repo? But it seems to correlate with when I forked them, at least a quick check says that.)

@QuLogic QuLogic closed this Jun 4, 2025
@QuLogic QuLogic reopened this Jun 4, 2025
@QuLogic QuLogic merged commit 5535df4 into matplotlib:main Jun 4, 2025
66 of 73 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 4, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 4, 2025
QuLogic added a commit that referenced this pull request Jun 4, 2025
…118-on-v3.10.3-doc

Backport PR #30118 on branch v3.10.3-doc (CI: Skip jobs on forks)
QuLogic added a commit that referenced this pull request Jun 5, 2025
…118-on-v3.10.x

Backport PR #30118 on branch v3.10.x (CI: Skip jobs on forks)
@oscargus oscargus deleted the forkci branch June 5, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Run cibuildwheel Run wheel building tests on a PR CI: testing CI configuration and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants