Skip to content

Add ability to toggle legend in the figure options dialog box #30128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ritvi-alagusankar
Copy link

@ritvi-alagusankar ritvi-alagusankar commented Jun 2, 2025

PR summary

Added the ability to toggle legend in the figure options dialog box, solving issue #11109. Changes in the PR:

  • Added a "Legend visible" checkbox to the figure options dialog box.
  • Implemented the callback to toggle legend visibility based on the value of the checkbox.

PR checklist

@ritvi-alagusankar ritvi-alagusankar marked this pull request as ready for review June 2, 2025 12:34
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@ritvi-alagusankar ritvi-alagusankar changed the title feat: add ability to toggle legend in the figure options dialog box Add ability to toggle legend in the figure options dialog box Jun 3, 2025
@ritvi-alagusankar
Copy link
Author

@rcomer gentle ping to help review this PR, this will be my first contribution to matplotlib. Please let me know if there are any changes to be made :)

@rcomer
Copy link
Member

rcomer commented Jun 12, 2025

I’m sorry but I am not currently available for reviewing. I also am not familiar with this part of the library so it is unlikely I will review it when I am available again.

@story645
Copy link
Member

@ritvi-alagusanka please add some tests for your code. You may wanna look at the tests for similar features as a model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add legend toggle to figure options dialog box
3 participants