Use pathlib in texmanager. #30431
Open
Use pathlib in texmanager. #30431
+34
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Aug 15, 2025
Only a few changes are needed. Note that make_png returns an absolute path so path joining is not even needed here. Also restore the recently incorrectly removed usage of dpi in generating the png filename. Also drop an unrelated but outdated comment re: background handling, which is obsolete since 8940c66 (look for `if hack: ...`).
|
I just realized that in #30426 I accidentally and wrongly removed the dpi arg when generating the png filename (at https://github.com/matplotlib/matplotlib/pull/30426/files#diff-6a0383194825a76389747fc0b369645f844ddc7fc7f30b300e4413fe40dc4b17L314); I fixed that in this commit as well so this should also be backported to 3.10.6, hence the milestoning (or I can make a separate commit with just that fix, if we want to be really granular...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a few changes are needed. Note that make_png returns an absolute path so path joining is not even needed here.
Also drop an unrelated but outdated comment re: background handling,
which is obsolete since 8940c66 (look for
if hack: ...).PR summary
PR checklist