Assume end of day on daterange filter when no time was passed #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It sounds like you may be using a Date filter when you should be using a DateTime filter. Or maybe you have data with time values, but want date only data? if you add a [DataTablesFilter(DataTablesFilterType.DateTimeRange)] as in the example, then the pickers should have a time component. If you don't want a time component, you can change your data source to map the DateTime columns to their date only values ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering a date range with start and end being the same date (without time) will result in no results being found since the dates are identical (e.g. 2020-03-26~2020-03-26).
This PR takes the end of day for the end date if only the date was passed to allow for same-day filtering.
Potentially this is a breaking change if users now rely on no results being returned