Skip to content

unix/coverage: Increase coverage of mp_binary_set_val_array_from_int. #16858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

unix/coverage: Increase coverage of mp_binary_set_val_array_from_int. #16858

wants to merge 1 commit into from

Conversation

projectgus
Copy link
Contributor

Summary

This function is only used from stm32/adc.c, but for now expand the manual coverage to include more of the supported typecodes.

Split out from #16311 where I originally added it to try and pass the project coverage CI check, but it actually wasn't enough.

This work was funded through GitHub Sponsors.

Trade-offs and Alternatives

  • As this function is only called from stm32/adc.c in MicroPython then we could totally remove it from the binary API, make it a static function in adc.c, and then it wouldn't need specific coverage code either.

@projectgus
unix/coverage: Increase coverage of mp_binary_set_val_array_from_int.
984f323 
This function is only used from stm32/adc.c, but for now expand
the coverage to cover most of the available typecodes.

This work was funded through GitHub Sponsors.

Signed-off-by: Angus Gratton <angus@redyak.com.au>
@projectgus projectgus added py-core Relates to py/ directory in source tests Relates to tests/ directory in source labels Mar 4, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (016ae19) to head (984f323).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16858   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         169      169           
  Lines       21864    21864           
=======================================
  Hits        21545    21545           
  Misses        319      319

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@projectgus projectgus mentioned this pull request Mar 4, 2025
Draft
2 tasks
@projectgus
Copy link
Contributor Author

Closing this as it seems like #16311 will either support removing mp_binary_set_val_array_from_int or it'll turn out we need it...

@projectgus projectgus closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
py-core Relates to py/ directory in source tests Relates to tests/ directory in source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@projectgus