py/mpconfig: Rename MICROPY_PY___FILE__ to MICROPY_MODULE___FILE__. #17886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code size report: |
dlech
reviewed
Aug 11, 2025
| @@ -23,6 +23,7 @@ | |||
| #define MICROPY_OPT_MATH_FACTORIAL (0) | |||
| #define MICROPY_REPL_EMACS_KEYS (0) | |||
| #define MICROPY_PY_BUILTINS_COMPLEX (0) | |||
There was a problem hiding this comment.
Looks like this one should be moved with the other PY_BUILTINS
There was a problem hiding this comment.
I agree this looks strange, but the order here actually matches the ordering in py/mpconfig.h, and that's what I was aiming for.
Probably MICROPY_PY_BUILTINS_COMPLEX could be renamed, or moved around in py/mpconfig.h.
projectgus
approved these changes
Aug 19, 2025
For consistency with other module-related configuration options. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
aa71e8f to
989abae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are now quite a few module related configuration options, of the form
MICROPY_MODULE_xxx.The old
MICROPY_PY___FILE__option has been around for a long time and it actually relates to modules, whether__file__is set on a module when import it.So, rename it to
MICROPY_MODULE___FILE__and organise it alongside the other module options inpy/mpconfig.h.Also, move
MICROPY_MODULE___ALL__so it's with all the other module options as well.Testing
Should be a no-op, but will be tested by CI anyway.
Trade-offs and Alternatives
Could leave things as they are, but IMO this is a worthy clean up.