alif/mpconfigport: Enable cryptolib and hashlib.md5/sha1. #17901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I agree we should enable all features as the flash allows it. I'll be cherry-picking these changes once they're merged. |
iabdalkader
approved these changes
Aug 14, 2025
They are enabled when SSL/mbedTLS is included in the firmware. These new features cost around +1400 bytes of code size. Signed-off-by: Damien George <damien@micropython.org>
b5ae49e to
f0f5abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
They are enabled when SSL/mbedTLS is included in the firmware (following, eg, the stm32 port). These new features cost around +1400 bytes of code size.
Testing
Tested on OPENMV_AE3, running the
tests/extmod/tests. They pass.Trade-offs and Alternatives
Could leave these disabled, but this port has plenty of flash and this brings it up to par with other networking boards.