extmod/modlwip: Remove unused include and functions. #17915
Merged
+0
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17915 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 171 171
Lines 22297 22297
=======================================
Hits 21938 21938
Misses 359 359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code size report: |
c48079a to
46dca0c
Compare
|
For clarity the motivation for this PR is that I was chasing down some problems and got led down the wrong path because I thought this stuff was still used. So removing it will avoid that chance for others in the future. |
dpgeorge
approved these changes
Aug 15, 2025
|
Actually, I think |
46dca0c to
41f66ac
Compare
|
Done. |
dpgeorge
approved these changes
Aug 16, 2025
The lwIP includes are now port-specific.
The `sys_arch_{,un}protect` functions are not used according to line 34
of `extmod/lwip-include/lwipopts_common.h`.
Neither have been touched in nearly a decade.
Signed-off-by: Thomas Watson <twatson52@icloud.com>
41f66ac to
bba3542
Compare
|
Thanks for updating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The lwipopts.h is now port-specific.
The
sys_arch_{,un}protectfunctions are not used according to line 34 ofextmod/lwip-include/lwipopts_common.h.Neither have been touched in nearly a decade.
Testing
Ensured that W5500-EVB-Pico builds and the resulting binary is unchanged.