Skip to content

unix: avoid crashing after heap lock in REPL #17965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

unix: avoid crashing after heap lock in REPL #17965

wants to merge 3 commits into from
+25 −0

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Aug 20, 2025 •
edited
Loading

Summary

Closes: #17934

There were 3 distinct scenarios I ran into:

Lock the heap, then type a long line:

>>> micropython.heap_lock()
>>> ffffffffffffffffffffffffffffffffffffffffFATAL: uncaught NLR 0x5555557593d0

Testing

I manually tested each variation I had discovered. I also added a CI-time test though I'm not 100% sure it's correct.

jepler added 2 commits August 20, 2025 16:17
@jepler
unix: Don't crash if heap locked in prompt_write_history.
8e596c6 
Signed-off-by: Jeff Epler <jepler@gmail.com>
@jepler
unix: Unlock heap before readline.
065f13b 
This is intended to be equivalent to the unlock in
shared/runtime/pyexec.c.

Signed-off-by: Jeff Epler <jepler@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.38%. Comparing base (b5fcb33) to head (3bad046).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17965   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         171      171           
  Lines       22296    22296           
=======================================
  Hits        21937    21937           
  Misses        359      359

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:   +40 +0.005% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@jepler
tests: Add test for heap lock in REPL.
3bad046 
Signed-off-by: Jeff Epler <jepler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"FATAL: uncaught NLR" with repl + heap lock
1 participant
@jepler