Skip to content

py/obj: Update with_finaliser version to match mp_obj_malloc_var. #18004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

py/obj: Update with_finaliser version to match mp_obj_malloc_var. #18004

wants to merge 1 commit into from
+4 −4

Conversation

AJMansfield
Copy link
Contributor

Cleans up 2423493, and fixes builds that include LFS but not MICROPY_ENABLE_FINALISER.

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.38%. Comparing base (af745a5) to head (d1d9716).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #18004   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         171      171           
  Lines       22296    22296           
=======================================
  Hits        21937    21937           
  Misses        359      359

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@AJMansfield AJMansfield force-pushed the malloc-with-finaliser-cleanup branch from 26a7b66 to 105f475 Compare August 29, 2025 03:11
@AJMansfield AJMansfield mentioned this pull request Aug 29, 2025
Open
@AJMansfield AJMansfield force-pushed the malloc-with-finaliser-cleanup branch from 105f475 to 4511a78 Compare August 29, 2025 03:34
@AJMansfield
py/obj: Update with_finaliser version to match mp_obj_malloc_var.
d1d9716 
Cleans up 2423493, and fixes builds
that include LFS but not MICROPY_ENABLE_FINALISER.

Signed-off-by: Anson Mansfield <amansfield@mantaro.com>
@AJMansfield AJMansfield force-pushed the malloc-with-finaliser-cleanup branch from 4511a78 to d1d9716 Compare August 29, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AJMansfield