tools/metrics.py: Compute mpy-cross size as part of size metrics. #18006
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien George <damien@micropython.org>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18006 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 171 171
Lines 22296 22296
=======================================
Hits 21937 21937
Misses 359 359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code size report: |
|
OK, so the size diff for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to
tools/metrics.pyto compute the size delta ofmpy-cross, alongside the sizes of port firmware. This is an easy and cheap addition becausempy-crossis usually built before the ports are.Although the size of
mpy-crossis not critical, it's still a nice indication of how the PR affects code size, and helps to eliminate any unwanted increases inmpy-cross.Testing
Tested locally, eg the output looks like (for no change):
CI will also test this, it should include
mpy-crossin the automatic report.Trade-offs and Alternatives
mpy-crossis already built as part of the code-size CI workflow, so we may as well report its size difference, along with port firmware size difference. It doesn't increase the time for the CI.