Fix capitalization of session id header #1325
Open
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ben221199 the language of this PR ("Fix") implies that something is broken/wrong with the header names, but since, as you note, header names are case-insensitive, this is more like an improvement in the consistency of the documentation, or some such thing. I'm pretty unopinionated about it, but it might be worth reframing the request in light of this, unless you think there's some other issue at stake. 👍 |
|
Hi @hesreallyhim, in the Discord server we had some discussion about this issue and one of the mods (specifically @olaservo) said this was an example of gray area pull request where stuff is between bugfixes and documentation updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the capitalization of the session id header from
Mcp-Session-IdtoMCP-Session-Id.Motivation and Context
The characters MCP are an abbreviation and it is usual in the English/American language to capitalize those characters. This is also usual in HTTP header names, like
MIME-VersionandALPN. Because MCP already has a headerMCP-Protocol-Versionwhere the capitalization is correct, it seems reasonable to me thatMcp-Session-Idwill follow the same rules and should be changed toMCP-Session-Id.How Has This Been Tested?
No, documentation update.
Breaking Changes
No, HTTP header names are case-insensitive, so compliant HTTP clients should not break.
Types of changes
Checklist
Additional context
Consider registering MCP headers at IANA: https://www.iana.org/assignments/http-fields/http-fields.xhtml.