Skip to content

Conversation

jonathanhefner
Copy link
Member

This copies the favicon from the documentation site to the blog.

Tested locally:

Before After
before after

This copies the favicon from the documentation site to the blog.
Copy link
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@cliffhall cliffhall merged commit 6314f8d into modelcontextprotocol:main Aug 22, 2025
1 check passed
@cliffhall
Copy link
Member

@jonathanhefner The icon is showing up in Firefox, but not Chrome because the actual page heading has it as http not https so it's mixed content and won't render. We need to get at the template.
Screenshot 2025-08-23 at 11 46 11 AM

@jonathanhefner
Copy link
Member Author

The icon is showing up in Firefox, but not Chrome because the actual page heading has it as http not https so it's mixed content and won't render. We need to get at the template.

The template uses the base URL that is passed to Hugo: https://github.com/adityatelange/hugo-PaperMod/blob/5a4651783fa9159123d947bd3511b355146d4797/layouts/partials/head.html#L93

So the problem is actually that our build action is passing an http URL instead of an https URL here:

cd blog && hugo \
--gc \
--minify \
--baseURL "${{ steps.pages.outputs.base_url }}/"

I believe the fix is to enforce HTTPS for our GitHub Pages, but I do not have sufficient permissions to enable that option. (Alternatively, we could remove that CLI option in favor of the value in hugo.toml; however, I think it is good to have the build action control the URL.)

@dsp-ant Sorry for the ping, but could you look into enabling the "Enforce HTTPS" option for the blog pages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants