Skip to content

chore: drop raw-body dependency #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Aug 20, 2025

Motivation and Context

raw-body depends on iconv-lite for charset support, which is quite hefty. Since the MCP spec states "JSON-RPC messages MUST be UTF-8 encoded", I don't think we need that. This PR replaces raw-body.

How Has This Been Tested?

Unit tests still pass, no tests added.

Breaking Changes

Technically, this drops support for charsets other than the ones listed in https://nodejs.org/api/buffer.html#buffers-and-character-encodings. This is unlikely to be noticed by anyone.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

I'll open a second PR to remove express. cc @cliffhall for review.

@Skn0tt Skn0tt requested a review from a team as a code owner August 20, 2025 05:31
@Skn0tt Skn0tt requested a review from felixweinberger August 20, 2025 05:31
Copy link
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor looks good, tests run locally, tested with src/examples/simpleStreamableHttp.ts. However package-lock.json still contains raw-body package.

@Skn0tt
Copy link
Contributor Author

Skn0tt commented Aug 20, 2025

That's because it's a transitive dependency of express.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants