Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mongodb-js/boxednode
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: mongodb-js/boxednode
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix-Wpessimizing-move
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Dec 12, 2024

  1. fix: address -Wpessimizing-move warning in binary blob helpers 

    Fixes:

    ../src/node_main.cc:945:52: warning: moving a temporary object prevents copy elision
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeCodeCacheVector()));
                                                      ^
    ../src/node_main.cc:945:52: note: remove std::move call here
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeCodeCacheVector()));
                                                      ^~~~~~~~~~                             ~
    ../src/node_main.cc:986:52: warning: moving a temporary object prevents copy elision
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeSnapshotBlobVector()));
                                                      ^
    ../src/node_main.cc:986:52: note: remove std::move call here
        std::vector<char>* str = new std::vector<char>(std::move(GetBoxednodeSnapshotBlobVector()));
    @addaleax
    addaleax committed Dec 12, 2024
    Configuration menu
    Copy the full SHA
    fa696e4 View commit details
    Browse the repository at this point in the history
Loading