feat: stub some hooks for the MCP server #1107
Open
+1,692
−778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds stubbed hooks for an MCP (Model Context Protocol) server, bumps VSCode types version, and fixes compilation errors that arose from the version update.
- Adds MCP server controller with start/stop functionality
- Updates VSCode types from 1.94.0 to 1.103.0
- Fixes icon path type changes from strings to
vscode.Uri - Updates test mocks to handle new VSCode API structure
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mcp/mcpController.ts | New MCP controller with server definition provider and start/stop methods |
| src/mdbExtensionController.ts | Integrates MCP controller and registers start/stop commands |
| src/commands/index.ts | Adds MCP server start/stop command definitions |
| package.json | Updates VSCode types and adds MCP server dependencies |
| src/explorer/*.ts | Updates icon path types from string to vscode.Uri |
| src/test/suite/stubs.ts | Adds encoding property to text document mock |
| src/test/suite/participant/participant.test.ts | Refactors chat request mocks and updates message content handling |
| Multiple test files | Updates icon path assertions to use toString() method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lerouxb
reviewed
Aug 21, 2025
.gitattributes
Outdated
| @@ -0,0 +1,2 @@ | |||
| package-lock.json linguist-vendored | |||
There was a problem hiding this comment.
what does this mean? (I googled it and it still isn't immediately obvious to me)
Comment on lines
+75
to
+76
| "vscode": "^1.101.1", | ||
| "node": "^20.19.0 || ^22.12.0 || >= 23.0.0", |
There was a problem hiding this comment.
Question: Should we check at some data on how many users are on version below the one mentioned here before proceeding with this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps the vscode types version and fixes some compile errors.